Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-10-09 Thread Greg KH
On Mon, Oct 09, 2017 at 01:21:23PM +0200, Martijn Coenen wrote: > On Fri, Sep 1, 2017 at 9:24 AM, Greg KH wrote: > > > > I've now applied patches 1, 2, 7, 9, 11, and 12 from this series to my > > tree, so feel free to rebase on it for the next round of these patches. >

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-10-09 Thread Martijn Coenen
On Fri, Sep 1, 2017 at 9:24 AM, Greg KH wrote: > > I've now applied patches 1, 2, 7, 9, 11, and 12 from this series to my > tree, so feel free to rebase on it for the next round of these patches. Thanks Greg. You should also be able to apply patch 10 from this series

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-09-01 Thread Greg KH
On Thu, Aug 31, 2017 at 02:00:54PM +0200, Martijn Coenen wrote: > On Thu, Aug 31, 2017 at 1:32 PM, Peter Zijlstra wrote: > > AFAIK people are actively working on fixing that. > > SCHED_DEADLINE was definitely looked at in the past. We certainly > don't use it on our own

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-08-31 Thread Peter Zijlstra
On Thu, Aug 31, 2017 at 02:00:54PM +0200, Martijn Coenen wrote: > Appreciate if you could take a look! In particular I'm curious why > this approach is considered "dodgy", or "engineered sideways" as > Thomas pointed out earlier. The fact that you could not reuse rt_mutex makes me very nervous.

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-08-31 Thread Martijn Coenen
On Thu, Aug 31, 2017 at 1:32 PM, Peter Zijlstra wrote: > AFAIK people are actively working on fixing that. SCHED_DEADLINE was definitely looked at in the past. We certainly don't use it on our own devices in Android Oreo, and I am not aware of any current plans to use it.

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-08-31 Thread Peter Zijlstra
On Thu, Aug 31, 2017 at 10:27:58AM +0200, Martijn Coenen wrote: > On Thu, Aug 31, 2017 at 10:18 AM, Peter Zijlstra wrote: > > You fail to support SCHED_DEADLINE, that's not optional. > > The reason I didn't include it is that we don't use SCHED_DEADLINE in > Android

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-08-31 Thread Peter Zijlstra
On Thu, Aug 31, 2017 at 10:04:20AM +0200, Martijn Coenen wrote: > Adds support for SCHED_BATCH/SCHED_FIFO/SCHED_RR priority inheritance > to the binder driver. The desired behavior is as follows: You fail to support SCHED_DEADLINE, that's not optional.

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-08-31 Thread Martijn Coenen
On Thu, Aug 31, 2017 at 10:18 AM, Peter Zijlstra wrote: > You fail to support SCHED_DEADLINE, that's not optional. The reason I didn't include it is that we don't use SCHED_DEADLINE in Android userspace. Can we add support for this in a follow-up patch, or do you consider

[PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

2017-08-31 Thread Martijn Coenen
Adds support for SCHED_BATCH/SCHED_FIFO/SCHED_RR priority inheritance to the binder driver. The desired behavior is as follows: Each thread in the binder threadpool runs at a default priority, which is typically nice 0. Binder nodes (endpoints that can receive binder transactions) can have a