Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-21 Thread Gao Xiang
On 2019/7/21 ??12:12, Gao Xiang wrote: > > > On 2019/7/21 12:05, Al Viro wrote: >> On Sun, Jul 21, 2019 at 11:08:42AM +0800, Gao Xiang wrote: >> >>> It is for debugging use as you said below, mainly for our internal >>> testers whose jobs are >>> to read kmsg logs and catch kernel problems.

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Gao Xiang
On 2019/7/21 12:05, Al Viro wrote: > On Sun, Jul 21, 2019 at 11:08:42AM +0800, Gao Xiang wrote: > >> It is for debugging use as you said below, mainly for our internal >> testers whose jobs are >> to read kmsg logs and catch kernel problems. sb->s_id (device number) >> maybe not >> straight-for

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Al Viro
On Sun, Jul 21, 2019 at 11:08:42AM +0800, Gao Xiang wrote: > It is for debugging use as you said below, mainly for our internal > testers whose jobs are > to read kmsg logs and catch kernel problems. sb->s_id (device number) > maybe not > straight-forward for them compared with dev_name... Huh? -

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Gao Xiang
Hi Al, On 2019/7/21 6:49, Al Viro wrote: > On Thu, Jul 11, 2019 at 10:57:34PM +0800, Gao Xiang wrote: >> This commit adds erofs super block operations, including (u)mount, >> remount_fs, show_options, statfs, in addition to some private >> icache management functions. > Could you explain what'

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Al Viro
On Thu, Jul 11, 2019 at 10:57:34PM +0800, Gao Xiang wrote: > This commit adds erofs super block operations, including (u)mount, > remount_fs, show_options, statfs, in addition to some private > icache management functions. Could you explain what's the point of this > + /* save the device name

[PATCH v2 03/24] erofs: add super block operations

2019-07-11 Thread Gao Xiang
This commit adds erofs super block operations, including (u)mount, remount_fs, show_options, statfs, in addition to some private icache management functions. Signed-off-by: Gao Xiang --- fs/erofs/super.c | 502 +++ 1 file changed, 502 insertions(+) cr