Re: [PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

2019-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2019 at 05:53:55AM -0500, Valdis Klētnieks wrote: > On Mon, 04 Nov 2019 13:04:14 +0300, Dan Carpenter said: > > On Sun, Nov 03, 2019 at 08:45:03PM -0500, Valdis Kletnieks wrote: > > > - if (sector_read(sb, sec, >buf_bh, 1) != FFS_SUCCESS) { > > > + if (sector_read(sb, sec, >buf_bh,

Re: [PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

2019-11-04 Thread Valdis Klētnieks
On Mon, 04 Nov 2019 13:04:14 +0300, Dan Carpenter said: > On Sun, Nov 03, 2019 at 08:45:03PM -0500, Valdis Kletnieks wrote: > > - if (sector_read(sb, sec, >buf_bh, 1) != FFS_SUCCESS) { > > + if (sector_read(sb, sec, >buf_bh, 1) != 0) { > > It's better to just remove the "!= 0" double negative.

Re: [PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

2019-11-04 Thread Dan Carpenter
On Sun, Nov 03, 2019 at 08:45:03PM -0500, Valdis Kletnieks wrote: > diff --git a/drivers/staging/exfat/exfat_cache.c > b/drivers/staging/exfat/exfat_cache.c > index 467b93630d86..28a67f8139ea 100644 > --- a/drivers/staging/exfat/exfat_cache.c > +++ b/drivers/staging/exfat/exfat_cache.c > @@

[PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

2019-11-03 Thread Valdis Kletnieks
Convert FFS_SUCCESS to 0. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 - drivers/staging/exfat/exfat_cache.c | 4 +- drivers/staging/exfat/exfat_core.c | 104 ++-- drivers/staging/exfat/exfat_super.c | 50 ++--- 4 files