Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
On Fri, Jun 29, 2018 at 2:43 PM, Sergio Paracuellos wrote: > Add driver support for gpio of MT7621 SoC. > > Signed-off-by: Sergio Paracuellos > --- > drivers/gpio/Kconfig | 8 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-mt7621.c | 320 > +

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
On Fri, Jun 29, 2018 at 6:52 PM, Sergio Paracuellos wrote: > On Fri, Jun 29, 2018 at 6:43 PM, kbuild test robot wrote: >> Hi Sergio, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on gpio/for-next] >> [also build test ERROR on v4.18-rc2 next-20180629] >> [if

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
On Fri, Jun 29, 2018 at 6:43 PM, kbuild test robot wrote: > Hi Sergio, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on gpio/for-next] > [also build test ERROR on v4.18-rc2 next-20180629] > [if your patch is applied to the wrong git tree, please drop us a note t

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread kbuild test robot
Hi Sergio, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.18-rc2 next-20180629] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
On Fri, Jun 29, 2018 at 3:31 PM, Dan Carpenter wrote: > Looks pretty clean to me. Sorry for not reviewing v1. Smatch (private > devel version) points out a little bit of dead code. > > drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() > warn: address of 'gpio_data->gc_ma

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Dan Carpenter
On Fri, Jun 29, 2018 at 04:31:35PM +0300, Dan Carpenter wrote: > Looks pretty clean to me. Sorry for not reviewing v1. Smatch (private > devel version) points out a little bit of dead code. > > drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() > warn: address of 'gpio_da

Re: [PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Dan Carpenter
Looks pretty clean to me. Sorry for not reviewing v1. Smatch (private devel version) points out a little bit of dead code. drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() warn: address of 'gpio_data->gc_map[i]' is non-NULL drivers/staging/mt7621-gpio/gpio-mt7621.c:225

[PATCH v2 1/2] gpio: mediatek: add driver for MT7621

2018-06-29 Thread Sergio Paracuellos
Add driver support for gpio of MT7621 SoC. Signed-off-by: Sergio Paracuellos --- drivers/gpio/Kconfig | 8 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-mt7621.c | 320 + 3 files changed, 329 insertions(+) create mode 100644 drivers