Re: [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-03 Thread Jeremy Sowden
On 2017-12-03, at 08:39:21 +0300, Dan Carpenter wrote: > On Sat, Dec 02, 2017 at 08:41:48PM +, Jeremy Sowden wrote: > > On 2017-12-02, at 10:35:06 +, Jeremy Sowden wrote: > > > On 2017-12-02, at 13:20:09 +0300, Dan Carpenter wrote: > > > > On Fri, Dec 01, 2017 at 05:19:37PM +, Jeremy So

Re: [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-02 Thread Dan Carpenter
On Sat, Dec 02, 2017 at 08:41:48PM +, Jeremy Sowden wrote: > On 2017-12-02, at 10:35:06 +, Jeremy Sowden wrote: > > On 2017-12-02, at 13:20:09 +0300, Dan Carpenter wrote: > > > On Fri, Dec 01, 2017 at 05:19:37PM +, Jeremy Sowden wrote: > > > > -#define DEFAULT_PIPE_INFO \ > > > > -{ \ >

Re: [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-02 Thread Jeremy Sowden
On 2017-12-02, at 20:41:48 +, Jeremy Sowden wrote: > On 2017-12-02, at 10:35:06 +, Jeremy Sowden wrote: > > On 2017-12-02, at 13:20:09 +0300, Dan Carpenter wrote: > > > On Fri, Dec 01, 2017 at 05:19:37PM +, Jeremy Sowden wrote: > > > > -#define DEFAULT_PIPE_INFO \ > > > > -{ \ > > > > -

Re: [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-02 Thread Jeremy Sowden
On 2017-12-02, at 10:35:06 +, Jeremy Sowden wrote: > On 2017-12-02, at 13:20:09 +0300, Dan Carpenter wrote: > > On Fri, Dec 01, 2017 at 05:19:37PM +, Jeremy Sowden wrote: > > > -#define DEFAULT_PIPE_INFO \ > > > -{ \ > > > - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* output_info */ \ > > >

Re: [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-02 Thread Jeremy Sowden
On 2017-12-02, at 13:20:09 +0300, Dan Carpenter wrote: > On Fri, Dec 01, 2017 at 05:19:37PM +, Jeremy Sowden wrote: > > -#define DEFAULT_PIPE_INFO \ > > -{ \ > > - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* output_info */ \ > > - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* vf_output_info */

Re: [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-02 Thread Dan Carpenter
On Fri, Dec 01, 2017 at 05:19:37PM +, Jeremy Sowden wrote: > -#define DEFAULT_PIPE_INFO \ > -{ \ > - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* output_info */ \ > - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* vf_output_info */ \ > - IA_CSS_BINARY_DEFAULT_FRAME_INFO, /* raw_outp

[PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-01 Thread Jeremy Sowden
The CSS API uses a lot of nested anonymous structs defined in object macros to assign default values to its data-structures. These have been changed to use compound-literals and designated initializers to make them more comprehensible and less fragile. The compound-literals can also be used in as