Re: [PATCH v2 12/33] staging: wfx: simplify API coherency check

2021-09-13 Thread Dan Carpenter
On Mon, Sep 13, 2021 at 10:30:24AM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > The 'channel' argument of hif_join() should never be NULL. hif_join() > does not have the responsibility to recover bug of caller. A call to > WARN() at the beginning of the function reminds this constrai

[PATCH v2 12/33] staging: wfx: simplify API coherency check

2021-09-13 Thread Jerome Pouiller
From: Jérôme Pouiller The 'channel' argument of hif_join() should never be NULL. hif_join() does not have the responsibility to recover bug of caller. A call to WARN() at the beginning of the function reminds this constraint to the developer. In current code, if the argument channel is NULL, mem