Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-20 Thread Benjamin Gaignard
2017-09-20 3:01 GMT+02:00 Laura Abbott : > On 09/19/2017 04:55 AM, Benjamin Gaignard wrote: >> >> 2017-09-19 13:02 GMT+02:00 Greg KH : >>> >>> On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote: Instead a getting one common device "/dev/ion" for all the heaps this patc

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Laura Abbott
On 09/19/2017 04:55 AM, Benjamin Gaignard wrote: 2017-09-19 13:02 GMT+02:00 Greg KH : On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote: Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting a

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Greg KH
On Tue, Sep 19, 2017 at 01:55:36PM +0200, Benjamin Gaignard wrote: > >> + > >> spin_lock_init(&heap->free_lock); > >> heap->free_list_size = 0; > >> > >> @@ -595,13 +610,9 @@ static int ion_device_create(void) > >> if (!idev) > >> return -ENOMEM; > >> > >> - idev

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Dan Carpenter
If you had spelled out how this patch breaks user space in the changelog then you wouldn't be catching so much flak for it now... You should fix that in v3. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.lin

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
2017-09-19 13:02 GMT+02:00 Greg KH : > On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote: >> Instead a getting one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap. >> Getting an entry per heap could allow to set sec

Re: [PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Greg KH
On Tue, Sep 19, 2017 at 12:25:38PM +0200, Benjamin Gaignard wrote: > Instead a getting one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones for

[PATCH v2 2/2] staging: ion: create one device entry per heap

2017-09-19 Thread Benjamin Gaignard
Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id match wit