On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote:
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote:
Btw, this whole function is terrible. It should be reading larger
chunks at once instead of get_user() for each character.
Just for the record, very small character
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote:
Out of curiosity, have you tested this patch?
On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote:
This patch fixes two sparse warnings related to lcd_write :
warning: incorrect type in argument 1 (different address
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote:
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote:
The aim of my patch was basically to add __user annotation. I tried to
keep the change minimal to lessen the risk of regression
Yes. That's the right approach. These
Out of curiosity, have you tested this patch?
On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote:
This patch fixes two sparse warnings related to lcd_write :
warning: incorrect type in argument 1 (different address spaces)
warning: incorrect type in initializer (incompatible
This patch fixes two sparse warnings related to lcd_write :
warning: incorrect type in argument 1 (different address spaces)
warning: incorrect type in initializer (incompatible argument 2
(different address spaces))
lcd_write can be used from kernel space (in panel_lcd_print) or from user
