Re: [PATCH v2 3/7] staging: unisys: cleanup goto in create_visor_device()

On Tue, Feb 23, 2016 at 12:05:22PM -0500, Benjamin Romer wrote: > -away_register: > + away_unregister: > device_unregister(>device); > -away: > + > + away: > put_device(>device); These cause checkpatch.pl errors. Also "away" is too generic a name. When I see "goto away;" I

Re: [PATCH v2 3/7] staging: unisys: cleanup goto in create_visor_device()

disregard this patch, I sent the wrong file. v3 coming. -- Ben ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 3/7] staging: unisys: cleanup goto in create_visor_device()

Get rid of the rc = -1 initialization. Return a meaningful error on failure in the function, or, the rc from a called function if it fails. Signed-off-by: Benjamin Romer --- v2: Put the goto back in. --- drivers/staging/unisys/visorbus/visorbus_main.c | 10