Re: [PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-29 Thread Benjamin Poirier
On 2020-06-30 01:43 +0800, Coiby Xu wrote: > On Mon, Jun 29, 2020 at 02:30:04PM +0900, Benjamin Poirier wrote: > > On 2020-06-27 22:58 +0800, Coiby Xu wrote: > > [...] > > > void ql_dump_qdev(struct ql_adapter *qdev) > > > { > > > @@ -1611,99 +1618,100 @@ void ql_dump_qdev(struct ql_adapter

Re: [PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-29 Thread Coiby Xu
On Mon, Jun 29, 2020 at 02:30:04PM +0900, Benjamin Poirier wrote: On 2020-06-27 22:58 +0800, Coiby Xu wrote: [...] void ql_dump_qdev(struct ql_adapter *qdev) { @@ -1611,99 +1618,100 @@ void ql_dump_qdev(struct ql_adapter *qdev) #ifdef QL_CB_DUMP void ql_dump_wqicb(struct wqicb *wqicb) { -

Re: [PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-28 Thread Benjamin Poirier
On 2020-06-27 22:58 +0800, Coiby Xu wrote: [...] > void ql_dump_qdev(struct ql_adapter *qdev) > { > @@ -1611,99 +1618,100 @@ void ql_dump_qdev(struct ql_adapter *qdev) > #ifdef QL_CB_DUMP > void ql_dump_wqicb(struct wqicb *wqicb) > { > - pr_err("Dumping wqicb stuff...\n"); > -

[PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-27 Thread Coiby Xu
Replace all pr_errs with netdev_err. Suggested-by: Joe Perches Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 568 1 file changed, 289 insertions(+), 279 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c