Signed-off-by: ZHAO Gang <gamer...@gmail.com>
---
I now see the good point of separating code style changes from others.
If your code is right, just edit code style change patch until reviewers
are satisfied :-)

 drivers/staging/et131x/et131x.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 7305fb5..881a8df 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -2307,11 +2307,6 @@ static int et131x_rx_dma_memory_alloc(struct 
et131x_adapter *adapter)
        rx_ring->rx_status_block = virt_addr;
        rx_ring->rx_status_bus = dma_addr;
 
-       pr_info("Packet Status Ring %llx\n",
-               (unsigned long long) rx_ring->ps_ring_physaddr);
-       pr_info("Receive Status Ring %llx\n",
-               (unsigned long long)rx_ring->rx_status_bus);
-
        rx_ring->num_rfd = NIC_DEFAULT_NUM_RFD;
        /* The RFDs are going to be put on lists later on, so initialize the
         * lists now.
@@ -2332,8 +2327,9 @@ static void et131x_rx_dma_memory_free(struct 
et131x_adapter *adapter)
        WARN_ON(rx_ring->num_ready_recv != rx_ring->num_rfd);
 
        while (!list_empty(&rx_ring->recv_list)) {
-               rfd = (struct rfd *) list_entry(rx_ring->recv_list.next,
-                               struct rfd, list_node);
+               rfd = list_entry(rx_ring->recv_list.next,
+                                struct rfd,
+                                list_node);
 
                list_del(&rfd->list_node);
                rfd->skb = NULL;
@@ -2714,7 +2710,7 @@ static int et131x_tx_dma_memory_alloc(struct 
et131x_adapter *adapter)
        if (!tx_ring->tcb_ring)
                return -ENOMEM;
 
-       desc_size = (sizeof(struct tx_desc) * NUM_DESC_PER_RING_TX);
+       desc_size = sizeof(struct tx_desc) * NUM_DESC_PER_RING_TX;
        /* Allocate dma memory for Tx descriptors and Tx status block */
        tx_ring->tx_desc_ring = dma_alloc_coherent(&adapter->pdev->dev,
                                                   desc_size + sizeof(u32),
@@ -2741,7 +2737,7 @@ static void et131x_tx_dma_memory_free(struct 
et131x_adapter *adapter)
 
        if (adapter->tx_ring.tx_desc_ring) {
                /* Free Tx descriptors and Tx status block  memory */
-               desc_size = (sizeof(struct tx_desc) * NUM_DESC_PER_RING_TX);
+               desc_size = sizeof(struct tx_desc) * NUM_DESC_PER_RING_TX;
                dma_free_coherent(&adapter->pdev->dev,
                                  desc_size + sizeof(u32),
                                  adapter->tx_ring.tx_desc_ring,
-- 
1.8.3.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to