Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-28 Thread Greg Kroah-Hartman
On Thu, Nov 27, 2014 at 08:50:55PM +0100, Mariusz Gorski wrote: On Thu, Nov 27, 2014 at 07:57:06AM -0800, Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 07:24:17AM -0800, Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 02:26:59PM +0100, Mariusz Gorski wrote: On Wed, Nov 26, 2014 at

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-28 Thread Mariusz Gorski
On Fri, Nov 28, 2014 at 12:32:48PM -0800, Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 08:50:55PM +0100, Mariusz Gorski wrote: On Thu, Nov 27, 2014 at 07:57:06AM -0800, Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 07:24:17AM -0800, Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-28 Thread Greg Kroah-Hartman
On Fri, Nov 28, 2014 at 09:57:06PM +0100, Mariusz Gorski wrote: I tried to apply the 3rd, but it didn't apply due to patches I applied in your first set of 4 patches. Does that help? Yes, thanks. I've resent the patchset yesterday as v3: https://lkml.org/lkml/2014/11/27/805 It

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-27 Thread Mariusz Gorski
On Wed, Nov 26, 2014 at 01:58:01PM -0800, Greg Kroah-Hartman wrote: On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote: Avoid magic number and use a comparison with a defined value instead that checks whether module param has been set by the user to some value at loading time.

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-27 Thread Greg Kroah-Hartman
On Thu, Nov 27, 2014 at 02:26:59PM +0100, Mariusz Gorski wrote: On Wed, Nov 26, 2014 at 01:58:01PM -0800, Greg Kroah-Hartman wrote: On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote: Avoid magic number and use a comparison with a defined value instead that checks whether

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-27 Thread Greg Kroah-Hartman
On Thu, Nov 27, 2014 at 05:14:06PM +0100, Willy Tarreau wrote: On Thu, Nov 27, 2014 at 07:57:06AM -0800, Greg Kroah-Hartman wrote: And the reason I got confused was because you didn't label your second set of patches v2, which it was, I saw two separate series, one with a few patches, and

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-27 Thread Mariusz Gorski
On Thu, Nov 27, 2014 at 07:57:06AM -0800, Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 07:24:17AM -0800, Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 02:26:59PM +0100, Mariusz Gorski wrote: On Wed, Nov 26, 2014 at 01:58:01PM -0800, Greg Kroah-Hartman wrote: On Wed, Nov 19, 2014

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-27 Thread Willy Tarreau
On Thu, Nov 27, 2014 at 08:50:55PM +0100, Mariusz Gorski wrote: And the reason I got confused was because you didn't label your second set of patches v2, which it was, I saw two separate series, one with a few patches, and then 2 sets of 9, the second set labeled v2 so I thought they were

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-27 Thread Fabio Estevam
On Thu, Nov 27, 2014 at 7:05 PM, Willy Tarreau w...@1wt.eu wrote: Mariusz, for people who have to parse hundreds to thousands of e-mails a day, dealing with non-trivial operation modes like this is never easy. I think (I'll let Greg suggest what he prefers) that the most reliable thing to do

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-26 Thread Greg Kroah-Hartman
On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote: Avoid magic number and use a comparison with a defined value instead that checks whether module param has been set by the user to some value at loading time. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy

[PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-19 Thread Mariusz Gorski
Avoid magic number and use a comparison with a defined value instead that checks whether module param has been set by the user to some value at loading time. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- v2: Don't introduce new macros for param value check

Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

2014-11-19 Thread Willy Tarreau
On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote: Avoid magic number and use a comparison with a defined value instead that checks whether module param has been set by the user to some value at loading time. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com Acked-by: Willy