Re: [PATCH v2 6/6] staging: ks7010: factor out some functions from hostif_init

2018-03-26 Thread Dan Carpenter
On Fri, Mar 23, 2018 at 06:00:38PM +0100, Sergio Paracuellos wrote: > +static inline void hostif_pmklist_init(struct ks_wlan_private *priv) > +{ > + int i; > memset(&priv->pmklist, 0, sizeof(priv->pmklist)); Put a blank line after the declaration block. Otherwise it looks good. regards

[PATCH v2 6/6] staging: ks7010: factor out some functions from hostif_init

2018-03-23 Thread Sergio Paracuellos
This commit factors out some init functions from hostif_init to improve readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 76 ++ 1 file changed, 52 insertions(+), 24 deletions(-) diff --git a/drivers/staging/ks7010/ks_hos