Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Michael Tretter
On Tue, 21 Jan 2020 19:59:46 +0800, Chuhong Yuan wrote: > On Tue, Jan 21, 2020 at 4:23 PM Michael Tretter > wrote: > > > > On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > > > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > > > v4l2_ctrl_new* calls. > > > Add check

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Chuhong Yuan
On Tue, Jan 21, 2020 at 4:23 PM Michael Tretter wrote: > > On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > > v4l2_ctrl_new* calls. > > Add checks and error handlers to fix the problems. > > > > Signed-off-by: Chuhong

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Michael Tretter
On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > v4l2_ctrl_new* calls. > Add checks and error handlers to fix the problems. > > Signed-off-by: Chuhong Yuan > --- > Changes in v3: > - Make code cleaner. > - Add a ch

[PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-12 Thread Chuhong Yuan
allegro_open() misses checks for v4l2_m2m_ctx_init() and results of v4l2_ctrl_new* calls. Add checks and error handlers to fix the problems. Signed-off-by: Chuhong Yuan --- Changes in v3: - Make code cleaner. - Add a check for handler->error. .../staging/media/allegro-dvt/allegro-core.c |