Re: [PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
On 21/02/10 06:19PM, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 08:31:33PM +0530, Amey Narkhede wrote: > > On 21/02/10 03:55PM, Greg KH wrote: > > > On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote: > > > > Stack allocated buffers cannot be used for DMA > > > > on all

Re: [PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Dan Carpenter
On Wed, Feb 10, 2021 at 08:31:33PM +0530, Amey Narkhede wrote: > On 21/02/10 03:55PM, Greg KH wrote: > > On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote: > > > Stack allocated buffers cannot be used for DMA > > > on all architectures so allocate hci_packet buffer > > > using kmalloc.

Re: [PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
On 21/02/10 03:55PM, Greg KH wrote: > On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote: > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate hci_packet buffer > > using kmalloc. > > > > Signed-off-by: Amey Narkhede > > --- > > Changes in v3: > >

Re: [PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote: > Stack allocated buffers cannot be used for DMA > on all architectures so allocate hci_packet buffer > using kmalloc. > > Signed-off-by: Amey Narkhede > --- > Changes in v3: > - Remove superfluous buf pointer > - Reduce

[PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
Stack allocated buffers cannot be used for DMA on all architectures so allocate hci_packet buffer using kmalloc. Signed-off-by: Amey Narkhede --- Changes in v3: - Remove superfluous buf pointer - Reduce size of allocation of hci_packet to match number of bytes used for