Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread
On Tue, Feb 10, 2015 at 12:34:07AM +, Drokin, Oleg wrote: > > On Feb 9, 2015, at 4:34 PM, wrote: > >> There's a third coding style error in this file which I've chosen to > >> not fix for clarity's sake. It is: initializing min_watchdog_ratelimit > >> (static int) to 0 > > > > Please fix tha

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread Drokin, Oleg
On Feb 9, 2015, at 4:34 PM, wrote: >> There's a third coding style error in this file which I've chosen to >> not fix for clarity's sake. It is: initializing min_watchdog_ratelimit >> (static int) to 0 > > Please fix that too, it's not correct. Drop the comment there if you > think that's confu

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread
On Mon, Feb 09, 2015 at 07:20:30PM +0200, Tal Shorer wrote: > Fix the following coding style errors in > drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: > 1. initializing lnet_table_header (static pointer) to NULL > 2. missing spaces around '=' Those are two different things, and should b

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread Tal Shorer
Fix the following coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: 1. initializing lnet_table_header (static pointer) to NULL 2. missing spaces around '=' There's a third coding style error in this file which I've chosen to not fix for clarity's sake. It is: initiali