Re: [PATCH v3] staging: nrf24: add new driver for 2.4GHz radio transceiver

2018-10-19 Thread Marcin Ciupak
On Fri, Oct 19, 2018 at 09:58:01AM +0300, Dan Carpenter wrote: > Hi Marcin, > > Thank you for the patch! Perhaps something to improve: > > url: > https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-164230 > > smatch

Re: [PATCH v3] staging: nrf24: add new driver for 2.4GHz radio transceiver

2018-10-19 Thread Dan Carpenter
Hi Marcin, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-164230 smatch warnings: drivers/staging/nrf24/nrf24_if.c:538 nrf24_create_pipe() error: 'p->dev'

[PATCH v3] staging: nrf24: add new driver for 2.4GHz radio transceiver

2018-10-17 Thread Marcin Ciupak
This patch adds driver for Nordic Semiconductor nRF24L01+ radio transceiver. Signed-off-by: Marcin Ciupak --- Changes in v2: - add terminating newlines to all logging formats Changes in v3: - patch subject - comments cleanup - goto labels cleanup - scnprintf bugfix -