Re: [PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-04 Thread Sudip Mukherjee
On Thu, Dec 04, 2014 at 05:34:11PM +0800, Fred Chou wrote: > > > On 4/12/2014 4:30 PM, Sudip Mukherjee wrote: > > On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote: > >> > >> > >> On 4/12/2014 3:34 PM, Sudip Mukherjee wrote: > >>> On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:

Re: [PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-04 Thread Fred Chou
On 4/12/2014 4:30 PM, Sudip Mukherjee wrote: > On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote: >> >> >> On 4/12/2014 3:34 PM, Sudip Mukherjee wrote: >>> On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote: From: Fred Chou Fixed the following warnings in sparse: >>

Re: [PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-04 Thread Sudip Mukherjee
On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote: > > > On 4/12/2014 3:34 PM, Sudip Mukherjee wrote: > > On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote: > >> From: Fred Chou > >> > >> Fixed the following warnings in sparse: > >> > >> drivers/staging/rtl8192u/r8192U_core.c:670

Re: [PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-04 Thread Fred Chou
On 4/12/2014 3:34 PM, Sudip Mukherjee wrote: > On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote: >> From: Fred Chou >> >> Fixed the following warnings in sparse: >> >> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: >> symbol 'dump_eprom' was not declared. >> Should it

Re: [PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-03 Thread Sudip Mukherjee
On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote: > From: Fred Chou > > Fixed the following warnings in sparse: > > drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: > symbol 'dump_eprom' was not declared. > Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:

[PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-03 Thread Fred Chou
From: Fred Chou Fixed the following warnings in sparse: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: symbol 'ComputeTxTime' was not declared.