This is obviously much better and easier to review. I ended up
reviewing it like I would normal code instead of staging code. My main
thing is could you please re-write the module init error handling so
that each function does its own error handling instead of just calling
vbox_driver_unload().
Hi,
On 22-06-17 14:03, Dan Carpenter wrote:
> This is obviously much better and easier to review. I ended up
> reviewing it like I would normal code instead of staging code. My main
> thing is could you please re-write the module init error handling so
> that each function does its own error ha
Hi,
On 26-06-17 18:24, Daniel Vetter wrote:
On Mon, Jun 26, 2017 at 06:06:19PM +0200, Hans de Goede wrote:
Hi,
On 23-06-17 11:31, Daniel Vetter wrote:
On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card us
Hello Hans,
26.06.2017 18:06, Hans de Goede wrote:
> Hi,
>
> On 23-06-17 11:31, Daniel Vetter wrote:
>> On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote:
[vboxvideo driver submission information to staging.]
>>
>> In the end it's up to you, but our experience in drm with -staging has
On Mon, Jun 26, 2017 at 04:55:46PM +0200, Hans de Goede wrote:
> >> +int vbox_dumb_create(struct drm_file *file,
> >> + struct drm_device *dev, struct drm_mode_create_dumb *args)
> >> +{
> >> + int ret;
> >> + struct drm_gem_object *gobj;
> >> + u32 handle;
> >> +
> >> + args->pit
