Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-04 Thread George Spelvin
On Sat, Apr 04, 2020 at 08:25:37PM +0300, Dan Carpenter wrote: > On Fri, Apr 03, 2020 at 11:40:28PM +, George Spelvin wrote: >> I understand that it's addressed more to patch authors than >> maintainers forwarding them, but I've read that thing a dozen times, >> and the description of S-o-b alw

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-04 Thread Dan Carpenter
On Fri, Apr 03, 2020 at 11:40:28PM +, George Spelvin wrote: > I understand that it's addressed more to patch authors than > maintainers forwarding them, but I've read that thing a dozen times, > and the description of S-o-b always seemed to be about copyright. > It's to say that you didn't ad

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-04 Thread Kalle Valo
George Spelvin writes: > On Fri, Apr 03, 2020 at 12:10:29PM +0300, Dan Carpenter wrote: >> On Thu, Apr 02, 2020 at 03:30:34PM +, George Spelvin wrote: >> > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: >> > > I don't know how this patch made it through two versions without an

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-03 Thread George Spelvin
On Fri, Apr 03, 2020 at 12:10:29PM +0300, Dan Carpenter wrote: > On Thu, Apr 02, 2020 at 03:30:34PM +, George Spelvin wrote: > > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: > > > I don't know how this patch made it through two versions without anyone > > > complaining that th

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-03 Thread Dan Carpenter
On Thu, Apr 02, 2020 at 03:30:34PM +, George Spelvin wrote: > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: > > I don't know how this patch made it through two versions without anyone > > complaining that this paragraph should be done as a separate patch... > > I often fold co

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-02 Thread George Spelvin
On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: > I don't know how this patch made it through two versions without anyone > complaining that this paragraph should be done as a separate patch... I often fold comment (and spacing/formatting) patches in to a main patch, when touching a

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-02 Thread Ajay.Kathat
Hi Dan, On 02/04/20 1:57 pm, Dan Carpenter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Mar 26, 2020 at 03:23:36PM +, ajay.kat...@microchip.com wrote: >> From: George Spelvin >> >> The code in lib/ is the desired polynomia

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-02 Thread Dan Carpenter
On Thu, Mar 26, 2020 at 03:23:36PM +, ajay.kat...@microchip.com wrote: > From: George Spelvin > > The code in lib/ is the desired polynomial, and even includes > the 1-bit left shift in the table rather than needing to code > it explicitly. > > While I'm in Kconfig, add a description of what

[PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-03-26 Thread Ajay.Kathat
From: George Spelvin The code in lib/ is the desired polynomial, and even includes the 1-bit left shift in the table rather than needing to code it explicitly. While I'm in Kconfig, add a description of what a WILC1000 is. Kconfig questions that require me to look up a data sheet to find out tha