Re: [PATCH v3] staging: xgifb: remove macros with hidden variable

2017-12-02 Thread Dan Carpenter
Much nicer. Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3] staging: xgifb: remove macros with hidden variable

2017-12-01 Thread Joshua Abraham
This patch removes macros in XGI_main.h that contain a xgifb_info variable. These macros hurt readability by hiding said variable behind a define. It also uses a temporary variable to keep the replaced code from getting too long. Signed-off-by: Joshua Abraham --- drivers/staging/xgifb/XGI_main