On Jan 13, 2014, at 11:56 PM, Dilger, Andreas andreas.dil...@intel.com wrote:
Begin forwarded message:
From: Greg KH gre...@linuxfoundation.org
Subject: Re: [PATCH v3 1/2] Staging: lustre: Refactor the function
interval_erase_color() in /lustre/ldlm/interval_tree.c
Date: January 11
On Tue, Jan 14, 2014 at 1:31 PM, Xiong, Jinshan jinshan.xi...@intel.com wrote:
On Jan 13, 2014, at 11:56 PM, Dilger, Andreas andreas.dil...@intel.com
wrote:
Begin forwarded message:
From: Greg KH gre...@linuxfoundation.org
Subject: Re: [PATCH v3 1/2] Staging: lustre: Refactor
...@intel.commailto:andreas.dil...@intel.com wrote:
Begin forwarded message:
From: Greg KH gre...@linuxfoundation.orgmailto:gre...@linuxfoundation.org
Subject: Re: [PATCH v3 1/2] Staging: lustre: Refactor the function
interval_erase_color() in /lustre/ldlm/interval_tree.c
Date: January 11, 2014 at 1:33:58 PM MST
On Sat, Jan 11, 2014 at 04:30:33PM +0530, Monam Agarwal wrote:
The function interval_erase_color() in lustre/ldlm/interval_tree.c is
too long and can be refactored. Most of the statements are same for if
and else conditions. I am passing a new variable n based on which the
differences are
I took n as a flag to decide whether parent-in_left == node is true
or not in the called function.
Should I use some other name for the flag.
On Sat, Jan 11, 2014 at 4:49 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sat, Jan 11, 2014 at 04:30:33PM +0530, Monam Agarwal wrote:
The
On Sat, Jan 11, 2014 at 04:56:44PM +0530, Monam Agarwal wrote:
I took n as a flag to decide whether parent-in_left == node is true
or not in the called function.
So n stands for node?
Should I use some other name for the flag.
Yes.
regards,
dan carpenter
On Sat, Jan 11, 2014 at 5:09 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sat, Jan 11, 2014 at 04:56:44PM +0530, Monam Agarwal wrote:
I took n as a flag to decide whether parent-in_left == node is true
or not in the called function.
So n stands for node?
Should I use some other name
