Re: [PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-14 Thread Nishad Kamdar
On Sun, Nov 11, 2018 at 12:31:54PM +, Jonathan Cameron wrote: > On Sun, 11 Nov 2018 12:24:05 + > Jonathan Cameron wrote: > > > On Fri, 9 Nov 2018 13:05:17 +0530 > > Nishad Kamdar wrote: > > > > > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin > > > instead of the depreca

Re: [PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-11 Thread Jonathan Cameron
On Sun, 11 Nov 2018 12:24:05 + Jonathan Cameron wrote: > On Fri, 9 Nov 2018 13:05:17 +0530 > Nishad Kamdar wrote: > > > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin > > instead of the deprecated old non-descriptor interface. > > > > Signed-off-by: Nishad Kamdar > Appli

Re: [PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-11 Thread Jonathan Cameron
On Fri, 9 Nov 2018 13:05:17 +0530 Nishad Kamdar wrote: > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin > instead of the deprecated old non-descriptor interface. > > Signed-off-by: Nishad Kamdar Applied to the togreg branch of iio.git and pushed out as testing for the autobuilde

Re: [PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-09 Thread Ardelean, Alexandru
On Fri, 2018-11-09 at 13:05 +0530, Nishad Kamdar wrote: > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin > instead of the deprecated old non-descriptor interface. > Patch looks good. I do have some thoughts about it. See inline. > Signed-off-by: Nishad Kamdar > --- > drivers/s

Re: [PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-09 Thread Ardelean, Alexandru
On Fri, 2018-11-09 at 08:05 +, Ardelean, Alexandru wrote: > On Fri, 2018-11-09 at 13:05 +0530, Nishad Kamdar wrote: > > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin > > instead of the deprecated old non-descriptor interface. > > > > Patch looks good. > I do have some thought

[PATCH v3 1/4] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-11-08 Thread Nishad Kamdar
Use the gpiod interface for rdwr_pin, convert_pin and busy_pin instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/adc/ad7816.c | 80 ++-- 1 file changed, 34 insertions(+), 46 deletions(-) diff --git a/drivers/