Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-23 Thread Gao Xiang
On 2019/7/23 8:31, David Sterba wrote: > On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: >> On 2019/7/22 6:18, David Sterba wrote: >>> On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: +choice + prompt "EROFS Data Decompression mode" + depends on

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-23 Thread David Sterba
On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: > On 2019/7/22 6:18, David Sterba wrote: > > On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: > >> +choice > >> + prompt "EROFS Data Decompression mode" > >> + depends on EROFS_FS_ZIP > >> + default

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Gao Xiang
On 2019/7/22 11:12, Theodore Y. Ts'o wrote: > On Mon, Jul 22, 2019 at 10:16:44PM +0800, Gao Xiang wrote: >> OK, I will give a try. One point I think is how to deal with the case >> if there is already cached information when remounting as well as you said. >> >> As the first step, maybe the

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Theodore Y. Ts'o
On Mon, Jul 22, 2019 at 10:16:44PM +0800, Gao Xiang wrote: > OK, I will give a try. One point I think is how to deal with the case > if there is already cached information when remounting as well as you said. > > As the first step, maybe the mount option can be defined as > allowing/forbiding

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Gao Xiang
Hi Ted, On 2019/7/22 9:25, Theodore Y. Ts'o wrote, > On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: >>> The number of individual Kconfig options is quite high, are you sure you >>> need them to be split like that? >> >> You mean the above? these are 3 cache strategies, which

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Theodore Y. Ts'o
On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: > > The number of individual Kconfig options is quite high, are you sure you > > need them to be split like that? > > You mean the above? these are 3 cache strategies, which impact the > runtime memory consumption and performance. I tend

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Gao Xiang
Hi David, On 2019/7/22 6:18, David Sterba wrote: > On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: >> +choice >> +prompt "EROFS Data Decompression mode" >> +depends on EROFS_FS_ZIP >> +default EROFS_FS_ZIP_CACHE_READAROUND >> +help >> + EROFS supports three

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread David Sterba
On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: > +choice > + prompt "EROFS Data Decompression mode" > + depends on EROFS_FS_ZIP > + default EROFS_FS_ZIP_CACHE_READAROUND > + help > + EROFS supports three options for decompression. > + "In-place I/O Only"

[PATCH v3 23/24] erofs: introduce cached decompression

2019-07-21 Thread Gao Xiang
This patch adds strategies which can be selected by users in order to cache both incomplete ends of compressed physical clusters as a complement of in-place I/O in order to boost random read, but it costs more memory than the in-place I/O only. Signed-off-by: Gao Xiang --- fs/erofs/Kconfig|