Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-28 Thread Ezequiel Garcia
Hi Mauro, On Wed, 2021-04-28 at 08:44 +0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Apr 2021 08:27:42 +0200 > Mauro Carvalho Chehab escreveu: > > > Em Tue, 27 Apr 2021 12:18:32 -0300 > > Ezequiel Garcia escreveu: > > > > > On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote:  > > > > On

Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-28 Thread Mauro Carvalho Chehab
Em Wed, 28 Apr 2021 08:27:42 +0200 Mauro Carvalho Chehab escreveu: > Em Tue, 27 Apr 2021 12:18:32 -0300 > Ezequiel Garcia escreveu: > > > On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote: > > > On 2021-04-27 11:27, Mauro Carvalho Chehab wrote: > > > > Despite other *_get()/*_put()

Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-28 Thread Mauro Carvalho Chehab
Em Tue, 27 Apr 2021 12:18:32 -0300 Ezequiel Garcia escreveu: > On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote: > > On 2021-04-27 11:27, Mauro Carvalho Chehab wrote: > > > Despite other *_get()/*_put() functions, where usage count is > > > incremented only if not errors, the

Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-27 Thread Ezequiel Garcia
On Tue, 2021-04-27 at 16:08 +0100, Robin Murphy wrote: > On 2021-04-27 11:27, Mauro Carvalho Chehab wrote: > > Despite other *_get()/*_put() functions, where usage count is > > incremented only if not errors, the pm_runtime_get_sync() has > > a different behavior, incrementing the counter *even*

Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-27 Thread Robin Murphy
On 2021-04-27 11:27, Mauro Carvalho Chehab wrote: Despite other *_get()/*_put() functions, where usage count is incremented only if not errors, the pm_runtime_get_sync() has a different behavior, incrementing the counter *even* on errors. That's an error prone behavior, as people often forget

[PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-27 Thread Mauro Carvalho Chehab
Despite other *_get()/*_put() functions, where usage count is incremented only if not errors, the pm_runtime_get_sync() has a different behavior, incrementing the counter *even* on errors. That's an error prone behavior, as people often forget to decrement the usage counter. However, the hantro