Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-05 Thread Ardelean, Alexandru
On Wed, 2019-12-04 at 17:00 +, Mark Brown wrote: > On Wed, Dec 04, 2019 at 07:18:15AM +, Ardelean, Alexandru wrote: > > > One example (for spi-cpha): > > if (of_property_read_u32(nc, "spi-cpha", &tmp) == 0) { > > spi->mode |= SPI_CPHA_OVERRIDE; > > i

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-04 Thread Mark Brown
On Wed, Dec 04, 2019 at 07:18:15AM +, Ardelean, Alexandru wrote: > One example (for spi-cpha): > if (of_property_read_u32(nc, "spi-cpha", &tmp) == 0) { > spi->mode |= SPI_CPHA_OVERRIDE; > if (tmp) > spi->mode |= SPI_CPHA; We could al

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-04 Thread Mark Brown
On Tue, Dec 03, 2019 at 04:51:54PM +, Jonathan Cameron wrote: > If the driver picks a mode because that's what it says on the datasheet > it prevents odd board configurations from working. The question > becomes whether it makes sense in general to assume those odd board > conditions don't ex

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-03 Thread Ardelean, Alexandru
On Tue, 2019-12-03 at 16:51 +, Jonathan Cameron wrote: > On Tue, 3 Dec 2019 16:38:50 + > Mark Brown wrote: > > > On Sun, Dec 01, 2019 at 11:40:32AM +, Jonathan Cameron wrote: > > > > > +CC Mark as we probably need a more general view point on > > > the question of whether SPI mode sh

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-03 Thread Mark Brown
On Sun, Dec 01, 2019 at 11:40:32AM +, Jonathan Cameron wrote: > +CC Mark as we probably need a more general view point on > the question of whether SPI mode should be enforced by binding > or in the driver. Not sure I see the question here, I think I was missing a bit of the conversation? It

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-03 Thread Jonathan Cameron
On Tue, 3 Dec 2019 16:38:50 + Mark Brown wrote: > On Sun, Dec 01, 2019 at 11:40:32AM +, Jonathan Cameron wrote: > > > +CC Mark as we probably need a more general view point on > > the question of whether SPI mode should be enforced by binding > > or in the driver. > > Not sure I see t

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-01 Thread Jonathan Cameron
+CC Mark as we probably need a more general view point on the question of whether SPI mode should be enforced by binding or in the driver. On Mon, 25 Nov 2019 07:51:30 + "Ardelean, Alexandru" wrote: > On Sat, 2019-11-23 at 11:41 +, Jonathan Cameron wrote: > > On Sat, 23 Nov 2019 02:19:

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-11-24 Thread Ardelean, Alexandru
On Sat, 2019-11-23 at 11:41 +, Jonathan Cameron wrote: > On Sat, 23 Nov 2019 02:19:27 -0300 > Rodrigo Carvalho wrote: > > > This patch add device tree binding documentation for ADIS16240. > > > > Signed-off-by: Rodrigo Ribeiro Carvalho My bad for the late timing on this. I'm slightly more

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-11-23 Thread Jonathan Cameron
On Sat, 23 Nov 2019 02:19:27 -0300 Rodrigo Carvalho wrote: > This patch add device tree binding documentation for ADIS16240. > > Signed-off-by: Rodrigo Ribeiro Carvalho No problem with this patch, but I definitely want to see an accompanying one enforcing the SPI mode in the driver. Right now

[PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-11-22 Thread Rodrigo Carvalho
This patch add device tree binding documentation for ADIS16240. Signed-off-by: Rodrigo Ribeiro Carvalho --- V4: - Remove spi-cpha and spi-cpol in binding example, since this driver supports only one timing mode. .../bindings/iio/accel/adi,adis16240.yaml | 49 +++ 1 file ch