Re: [PATCH v4] staging: nvec: change usage of slave to secondary

On 02/08/20 1:43 pm, Marc Dietrich wrote: > Hello Rohit, > > On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote: > >> changed usage of slave (which is deprecated) to secondary without breaking >> the driver >> >> Tested-by: Dan Carpenter >> Acked-by: Marc Dietrich >> Signed-off-by: Rohit K Bharadwaj

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

Hello Rohit, On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote: changed usage of slave (which is deprecated) to secondary without breaking the driver Tested-by: Dan Carpenter Acked-by: Marc Dietrich Signed-off-by: Rohit K Bharadwaj please don't add "*-by"'s by yourself when you send a new pat

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

Hi, On Sat, 25 Jul 2020, Michał Mirosław wrote: On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: On 25/07/20 5:31 pm, Michał Mirosław wrote: On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: changed usage of slave (which is deprecated) to secondary without

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

On 25/07/20 6:20 pm, Michał Mirosław wrote: > On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: >> On 25/07/20 5:31 pm, Michał Mirosław wrote: >>> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: changed usage of slave (which is deprecated) to secondary witho

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: > On 25/07/20 5:31 pm, Michał Mirosław wrote: > > On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: > >> changed usage of slave (which is deprecated) to secondary without breaking > >> the driver > > > > The relev

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

On 25/07/20 5:31 pm, Michał Mirosław wrote: > On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: >> changed usage of slave (which is deprecated) to secondary without breaking >> the driver > > The relevant I2C and SMBus standards use master/slave terminology. Why are > you changin

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: > changed usage of slave (which is deprecated) to secondary without breaking > the driver The relevant I2C and SMBus standards use master/slave terminology. Why are you changing the names to something unfamiliar? If the reason ar

[PATCH v4] staging: nvec: change usage of slave to secondary

changed usage of slave (which is deprecated) to secondary without breaking the driver Tested-by: Dan Carpenter Acked-by: Marc Dietrich Signed-off-by: Rohit K Bharadwaj --- v4: undo the changes (which broke the driver) to this line: if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i