Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-03-03 Thread Greg Kroah-Hartman
On Mon, Feb 24, 2020 at 01:54:48PM +0530, Kaaira Gupta wrote: > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > instead of existing functions so that the debug and dump are > emitted at the same KERN_ > > Signed-off-by: Kaaira Gupta > --- > > changes since v1: make code of ql

Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Joe Perches
On Mon, 2020-02-24 at 22:48 +0530, Kaaira Gupta wrote: > On Mon, Feb 24, 2020 at 08:54:43AM -0800, Joe Perches wrote: > > On Mon, 2020-02-24 at 22:17 +0530, Kaaira Gupta wrote: > > > On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote: > > > > On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta

Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 08:54:43AM -0800, Joe Perches wrote: > On Mon, 2020-02-24 at 22:17 +0530, Kaaira Gupta wrote: > > On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote: > > > On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote: > > > > Simplify code in ql_mpi_core_to_log() by callin

Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Joe Perches
On Mon, 2020-02-24 at 22:17 +0530, Kaaira Gupta wrote: > On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote: > > On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote: > > > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > > > instead of existing functions so that the de

Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote: > On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote: > > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > > instead of existing functions so that the debug and dump are > > emitted at the same KERN_ > [] > > diff --

Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Joe Perches
On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote: > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > instead of existing functions so that the debug and dump are > emitted at the same KERN_ [] > diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c [

[PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Kaaira Gupta
Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() instead of existing functions so that the debug and dump are emitted at the same KERN_ Signed-off-by: Kaaira Gupta --- changes since v1: make code of ql_mpi_core_to_log() simpler. changes since v2: directly call the function inste