Re: [PATCH v4 1/5] staging: et131x: clean up code

2013-11-22 Thread Dan Carpenter
On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote: Otherwise this patch seems nice but it needs to be split up and resent. By the way, this mailing list is surely an open list, but I can't find how to subscribe it - the website at driverdev.osuosl.org said it has no

Re: [PATCH v4 1/5] staging: et131x: clean up code

2013-11-22 Thread ZHAO Gang
On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote: Otherwise this patch seems nice but it needs to be split up and resent. By the way, this mailing list is surely an open list, but I can't find how to

Re: [PATCH v4 1/5] staging: et131x: clean up code

2013-11-22 Thread Dan Carpenter
On Fri, Nov 22, 2013 at 07:37:58PM +0800, ZHAO Gang wrote: On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote: Otherwise this patch seems nice but it needs to be split up and resent. By the way,

Re: [PATCH v4 1/5] staging: et131x: clean up code

2013-11-22 Thread ZHAO Gang
On Fri, Nov 22, 2013 at 8:13 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Nov 22, 2013 at 07:37:58PM +0800, ZHAO Gang wrote: On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote: Otherwise

Re: [PATCH v4 1/5] staging: et131x: clean up code

2013-11-22 Thread Dan Carpenter
On Fri, Nov 22, 2013 at 08:35:39PM +0800, ZHAO Gang wrote: On Fri, Nov 22, 2013 at 8:13 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Nov 22, 2013 at 07:37:58PM +0800, ZHAO Gang wrote: On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri,

[PATCH v4 1/5] staging: et131x: clean up code

2013-11-21 Thread ZHAO Gang
1. change function name: et1310_phy_power_down - et1310_phy_power_switch change function name to better describe its functionality. 2. as TODO file suggested, do this sort of things to reduce split lines struct fbr_lookup *fbr; fbr = rx_local-fbr[id]; Then replace