Re: [PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller()

2019-01-10 Thread Nishad Kamdar
On Wed, Jan 09, 2019 at 11:58:24AM +0100, Johan Hovold wrote: > On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote: > > This patch drops gpio_chip_to_gb_gpio_controller(), > > and uses gpiochip_get_data() to retrieve the container > > of struct gpio_chip. > > So this will break the

Re: [PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller()

2019-01-09 Thread Johan Hovold
On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote: > This patch drops gpio_chip_to_gb_gpio_controller(), > and uses gpiochip_get_data() to retrieve the container > of struct gpio_chip. So this will break the driver, since gpiochip_add() sets the data pointer to NULL. These kind of

[PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller()

2018-12-22 Thread Nishad Kamdar
This patch drops gpio_chip_to_gb_gpio_controller(), and uses gpiochip_get_data() to retrieve the container of struct gpio_chip. Signed-off-by: Nishad Kamdar --- Changes in v4: - Introduce this change as a new patch. --- drivers/staging/greybus/gpio.c | 28 +--- 1 file