Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-12 Thread Hans Verkuil
On 10/12/17 19:56, Dmitry Osipenko wrote: > On 05.12.2017 16:03, Hans Verkuil wrote: >> On 12/05/17 13:17, Dmitry Osipenko wrote: >>> Hi Hans, >>> >>> On 04.12.2017 17:04, Hans Verkuil wrote: Hi Dmitry, As you already mention in the TODO, this should become a v4l2 codec driver.

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-10 Thread Dmitry Osipenko
On 10.12.2017 22:29, Nicolas Dufresne wrote: > Le dimanche 10 décembre 2017 à 21:56 +0300, Dmitry Osipenko a écrit : >>> I've CC-ed Maxime and Giulio as well: they are looking into adding support >>> for >>> the stateless allwinner codec based on this code as well. There may well be >>>

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-05 Thread Hans Verkuil
On 12/05/17 13:17, Dmitry Osipenko wrote: > Hi Hans, > > On 04.12.2017 17:04, Hans Verkuil wrote: >> Hi Dmitry, >> >> As you already mention in the TODO, this should become a v4l2 codec driver. >> >> Good existing examples are the coda, qcom/venus and mtk-vcodec drivers. >> >> One thing that is

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-05 Thread Dmitry Osipenko
Hi Hans, On 04.12.2017 17:04, Hans Verkuil wrote: > Hi Dmitry, > > As you already mention in the TODO, this should become a v4l2 codec driver. > > Good existing examples are the coda, qcom/venus and mtk-vcodec drivers. > > One thing that is not clear from this code is if the tegra hardware is

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-04 Thread Hans Verkuil
Hi Dmitry, As you already mention in the TODO, this should become a v4l2 codec driver. Good existing examples are the coda, qcom/venus and mtk-vcodec drivers. One thing that is not clear from this code is if the tegra hardware is a stateful or stateless codec, i.e. does it keep track of the

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-11-13 Thread Dan Carpenter
On Sat, Nov 11, 2017 at 04:06:52PM +0200, Vladimir Zapolskiy wrote: > > + if (!wait_dma) > > + return 0; > > + > > + err = readl_relaxed_poll_timeout(vde->bsev + INTR_STATUS, value, > > +!(value & BSE_DMA_BUSY), 1, 100); > > + if (err) { > > +

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-11-12 Thread Dmitry Osipenko
On 11.11.2017 17:06, Vladimir Zapolskiy wrote: > Hi Dmitry, > > I'll add just a couple of minor comments, in general the code looks > very good. > Thank you very much for the review! > On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: >> NVIDIA Tegra20/30/114/124/132 SoC's have video decoder

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-11-11 Thread Vladimir Zapolskiy
Hi Dmitry, I'll add just a couple of minor comments, in general the code looks very good. On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > NVIDIA Tegra20/30/114/124/132 SoC's have video decoder engine that > supports standard set of video formats like H.264 / MPEG-4 / WMV / VC1. > Currently

[PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-10-19 Thread Dmitry Osipenko
NVIDIA Tegra20/30/114/124/132 SoC's have video decoder engine that supports standard set of video formats like H.264 / MPEG-4 / WMV / VC1. Currently implemented decoding of CAVLC H.264 on Tegra20 only. Signed-off-by: Dmitry Osipenko --- drivers/staging/Kconfig|