Re: [PATCH v5 1/7] staging: et131x: make some tweaks to reduce split lines

2013-12-03 Thread Greg Kroah-Hartman
On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote: 1. As TODO list suggested, do this sort of things to reduce split lines: struct fbr_lookup *fbr; fbr = rx_local-fbr[id]; Then replace all the instances of rx_local-fbr[id] with fbr. 2. Some code style changes

Re: [PATCH v5 1/7] staging: et131x: make some tweaks to reduce split lines

2013-12-03 Thread Greg Kroah-Hartman
On Wed, Dec 04, 2013 at 01:51:41PM +0800, ZHAO Gang wrote: On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote: 1. As TODO list suggested, do this sort of things to reduce split lines: struct

Re: [PATCH v5 1/7] staging: et131x: make some tweaks to reduce split lines

2013-12-03 Thread ZHAO Gang
On Wed, Dec 4, 2013 at 3:09 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 01:51:41PM +0800, ZHAO Gang wrote: On Wed, Dec 4, 2013 at 12:38 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Nov 23, 2013 at 12:21:29AM +0800, ZHAO Gang wrote: 1.

[PATCH v5 1/7] staging: et131x: make some tweaks to reduce split lines

2013-11-22 Thread ZHAO Gang
1. As TODO list suggested, do this sort of things to reduce split lines: struct fbr_lookup *fbr; fbr = rx_local-fbr[id]; Then replace all the instances of rx_local-fbr[id] with fbr. 2. Some code style changes Signed-off-by: ZHAO Gang gamer...@gmail.com --- v4 - v5: split