Re: [Outreachy kernel] Re: [PATCH v7] staging: xgifb: correct the multiple line dereference

2017-02-28 Thread Joe Perches
On Tue, 2017-02-28 at 12:24 +0100, Julia Lawall wrote: > It's drifting a little bit from the original issue, but the whole *i thing > is not very nice. The function is used in only one place, and the call > looks like this: > >temp = XGI_AjustCRT2Rate(ModeIdIndex, RefreshRateTable

Re: [Outreachy kernel] Re: [PATCH v7] staging: xgifb: correct the multiple line dereference

2017-02-28 Thread Julia Lawall
On Tue, 28 Feb 2017, Joe Perches wrote: > On Tue, 2017-02-28 at 16:15 +0530, Arushi Singhal wrote: > > Error reported by checkpatch.pl as "avoid multiple line dereference". > > Addition of new variables to make the code more readable. > > You should probably split this into 2 patches, one for >

Re: [PATCH v7] staging: xgifb: correct the multiple line dereference

2017-02-28 Thread Joe Perches
On Tue, 2017-02-28 at 16:15 +0530, Arushi Singhal wrote: > Error reported by checkpatch.pl as "avoid multiple line dereference". > Addition of new variables to make the code more readable. You should probably split this into 2 patches, one for each file. What Julia said about finding a better/sho

[PATCH v7] staging: xgifb: correct the multiple line dereference

2017-02-28 Thread Arushi Singhal
Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable. Signed-off-by: Arushi Singhal --- changes in v7 - Improve the coding style. - Introduced new variables. drivers/staging/xgifb/XGI_main_26.c | 29 ++