Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-03 Thread Chao Yu
On 2019/9/2 22:20, David Sterba wrote: > Oh right, I think the reasons are historical and that we can remove the > options nowadays. From the compatibility POV this should be safe, with > ACLs compiled out, no tool would use them, and no harm done when the > code is present but not used. > >

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread Gao Xiang
Hi Christoph, On Mon, Sep 02, 2019 at 08:06:40AM -0700, Christoph Hellwig wrote: > On Mon, Sep 02, 2019 at 04:20:37PM +0200, David Sterba wrote: > > Oh right, I think the reasons are historical and that we can remove the > > options nowadays. From the compatibility POV this should be safe, with >

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread Gao Xiang
Hi Christoph, On Mon, Sep 02, 2019 at 08:06:40AM -0700, Christoph Hellwig wrote: > On Mon, Sep 02, 2019 at 04:20:37PM +0200, David Sterba wrote: > > Oh right, I think the reasons are historical and that we can remove the > > options nowadays. From the compatibility POV this should be safe, with >

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread Christoph Hellwig
On Mon, Sep 02, 2019 at 04:20:37PM +0200, David Sterba wrote: > Oh right, I think the reasons are historical and that we can remove the > options nowadays. From the compatibility POV this should be safe, with > ACLs compiled out, no tool would use them, and no harm done when the > code is present

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread David Sterba
On Mon, Sep 02, 2019 at 09:51:59PM +0800, Chao Yu wrote: > On 2019-9-2 21:06, David Sterba wrote: > > On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote: > >>> +config EROFS_FS_XATTR > >>> + bool "EROFS extended attributes" > >>> + depends on EROFS_FS > >>> + default y > >>> + help

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread Chao Yu
On 2019-9-2 21:06, David Sterba wrote: > On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote: >>> +config EROFS_FS_XATTR >>> + bool "EROFS extended attributes" >>> + depends on EROFS_FS >>> + default y >>> + help >>> + Extended attributes are name:value pairs associated

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread David Sterba
On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote: > > +config EROFS_FS_XATTR > > + bool "EROFS extended attributes" > > + depends on EROFS_FS > > + default y > > + help > > + Extended attributes are name:value pairs associated with inodes by > > + the kernel or by

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread Gao Xiang
Hi Christoph, On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote: > > +config EROFS_FS_XATTR > > + bool "EROFS extended attributes" > > + depends on EROFS_FS > > + default y > > + help > > + Extended attributes are name:value pairs associated with inodes by > > +

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread Christoph Hellwig
> +config EROFS_FS_XATTR > + bool "EROFS extended attributes" > + depends on EROFS_FS > + default y > + help > + Extended attributes are name:value pairs associated with inodes by > + the kernel or by users (see the attr(5) manual page, or visit > +

[PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-08-14 Thread Gao Xiang
This implements xattr and posixacl functionalities. 1) Inline and shared xattrs are introduced for flexibility. Specifically, if the same xattr is used for a large number of inodes or the size of a xattr is so large that unsuitable to inline, a shared xattr will be used instead in xattr