Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-09 Thread Gujulan Elango, Hari Prasath (H.)
On Mon, Jun 08, 2015 at 01:29:30PM -0700, gre...@linuxfoundation.org wrote: > On Mon, Jun 01, 2015 at 01:06:15PM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > This patch deletes all references to 'flipbuf'.Memory is allocated and > > freed but ne

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-08 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 01:06:15PM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This patch deletes all references to 'flipbuf'.Memory is allocated and > freed but never used anywhere in the driver.Also deleted an ununsed > Macro defined in the header fi

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 11:29:44PM +0200, Konrad Zapalowicz wrote: > On 06/01, Gujulan Elango, Hari Prasath (H.) wrote: > > From: Hari Prasath Gujulan Elango > > The above line should not be here and it will appear as long as the > email client is not configured correctly. Just take a step back a

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread Konrad Zapalowicz
On 06/01, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango The above line should not be here and it will appear as long as the email client is not configured correctly. Just take a step back and fix it as this is something that you do once and then it remains *correct*

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread Sudip Mukherjee
On Mon, Jun 01, 2015 at 01:26:39PM +, Gujulan Elango, Hari Prasath (H.) wrote: > On Mon, Jun 01, 2015 at 04:18:17PM +0300, Dan Carpenter wrote: > > Really both patches should have been folded together. > > > > regards, > > dan carpenter > > > > Yes Dan they can very well be a single patch.I

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread Gujulan Elango, Hari Prasath (H.)
On Mon, Jun 01, 2015 at 04:18:17PM +0300, Dan Carpenter wrote: > Really both patches should have been folded together. > > regards, > dan carpenter > Yes Dan they can very well be a single patch.I have already sent multiple versions of this patch and its confusing.I will leave it as it is for n

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread Dan Carpenter
Really both patches should have been folded together. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango This patch deletes all references to 'flipbuf'.Memory is allocated and freed but never used anywhere in the driver.Also deleted an ununsed Macro defined in the header file. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/dgnc/dgnc_driver.c | 9 -