Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread Tobin C. Harding
On Mon, Nov 06, 2017 at 04:56:40PM +0300, Dan Carpenter wrote: > On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote: > > > > @@ -260,9 +261,10 @@ int visorchannel_signalremove(struct visorchannel > > > > *channel, u32 queue, > > > > void *msg) > > > >

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread Dan Carpenter
On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote: > > > @@ -260,9 +261,10 @@ int visorchannel_signalremove(struct visorchannel > > > *channel, u32 queue, > > > void *msg) > > > { > > > int rc; > > > - unsigned long flags; > > > > > > if

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread gre...@linuxfoundation.org
On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote: > On Mon, Nov 06, 2017 at 09:02:21AM +0100, gre...@linuxfoundation.org wrote: > > On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > > > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org > > >

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread Tobin C. Harding
On Mon, Nov 06, 2017 at 09:02:21AM +0100, gre...@linuxfoundation.org wrote: > On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > > > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: >

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread gre...@linuxfoundation.org
On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > > Hey Greg, we think the code for visorbus is ready to be moved out > > > of

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-05 Thread Tobin C. Harding
On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > Hey Greg, we think the code for visorbus is ready to be moved out > > of staging, can you review it to see if we have missed anything? > > I think

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-04 Thread Dan Carpenter
drivers/staging/unisys/visorbus/visorchipset.c 588 static void *parser_name_get(struct parser_context *ctx) 589 { 590 struct visor_controlvm_parameters_header *phdr; 591 592 phdr = >data; 593 if (phdr->name_offset + phdr->name_length >

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-03 Thread gre...@linuxfoundation.org
On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > Hey Greg, we think the code for visorbus is ready to be moved out > > of staging, can you review it to see if we have missed anything? > > I think

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-10-02 Thread gre...@linuxfoundation.org
On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > Hey Greg, we think the code for visorbus is ready to be moved out > of staging, can you review it to see if we have missed anything? I think your html email got rejected by the list :( > The files include: >