Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-05 Thread Larry Finger
On 01/05/2016 09:53 AM, Jes Sorensen wrote: Julian Calaby writes: Hi Sven, On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote: diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c index 1662c03c..57f5941 100644 --- a/drivers/staging/rtl872

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-05 Thread Jes Sorensen
Julian Calaby writes: > Hi Sven, > > On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote: >> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> index 1662c03c..57f5941 100644 >> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> +++ b

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-04 Thread Julian Calaby
Hi Sven, On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote: > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > index 1662c03c..57f5941 100644 > --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > +++ b/drivers/staging/rtl8723au/hal/rt

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-04 Thread Jes Sorensen
Sven Dziadek writes: > Remove byte order conversions. > Conversion is already done in usb_ops_linux.c when accessing usb port. > The deleted lines convert to little-endian and then call FillH2CCmd to > convert back. Additionally, they are applied to wrong types and > process wrong parts of variabl

[RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-04 Thread Sven Dziadek
Remove byte order conversions. Conversion is already done in usb_ops_linux.c when accessing usb port. The deleted lines convert to little-endian and then call FillH2CCmd to convert back. Additionally, they are applied to wrong types and process wrong parts of variables later on. Signed-off-by: Sve