On Mon, Jul 09, 2018 at 05:25:21PM +0300, Dan Carpenter wrote:
> On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> > +static ssize_t sysfs_write(struct device *dev, const char *buf,
> > + size_t count, unsigned int addr_offset)
> > +{
> > + struct
On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> +static ssize_t sysfs_write(struct device *dev, const char *buf,
> +size_t count, unsigned int addr_offset)
> +{
> + struct axis_fifo_local *device_wrapper = dev_get_drvdata(dev);
What does the "local" mean
On Mon, Jul 09, 2018 at 09:43:28AM +0200, Greg KH wrote:
> On Sun, Jul 08, 2018 at 02:25:38PM -0400, jacob feder wrote:
> > On Sun, Jul 8, 2018 at 9:28 AM Greg KH wrote:
> >
> > On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> > > Hi all,
> > > I have developed this
On Sun, Jul 08, 2018 at 02:25:38PM -0400, jacob feder wrote:
> On Sun, Jul 8, 2018 at 9:28 AM Greg KH wrote:
>
> On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> > Hi all,
> > I have developed this driver for a Xilinx-provided IP block for their
> Zynq
> > SoC.
On Sun, Jul 08, 2018 at 03:28:16PM +0200, Greg KH wrote:
> On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> > Hi all,
> > I have developed this driver for a Xilinx-provided IP block for their Zynq
> > SoC. I fixed all of the checkpatch.pl problems I knew how to. If someone
> > could
On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> Hi all,
> I have developed this driver for a Xilinx-provided IP block for their Zynq
> SoC. I fixed all of the checkpatch.pl problems I knew how to. If someone
> could chime in on how to fix the remaining few it would be appreciated.
>
Hi all,
I have developed this driver for a Xilinx-provided IP block for their Zynq
SoC. I fixed all of the checkpatch.pl problems I knew how to. If someone
could chime in on how to fix the remaining few it would be appreciated.
Also looking for feedback on general structure. It's my first driver