tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
debugfs_cleanup
head:   b23ebf4cbbc7a340acc9126d1fff4d39b20ef364
commit: 7c11b3df5cac0ff8a580a81f0b8a92148d66dc81 [116/120] ceph: fix changelog
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 7c11b3df5cac0ff8a580a81f0b8a92148d66dc81
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   fs/ceph/super.c: In function 'ceph_real_mount':
>> fs/ceph/super.c:932:7: error: void value not ignored as it ought to be
      err = ceph_fs_debugfs_init(fsc);
          ^

vim +932 fs/ceph/super.c

16725b9d Sage Weil          2009-10-06  895  
3d14c5d2 Yehuda Sadeh       2010-04-06  896  
3d14c5d2 Yehuda Sadeh       2010-04-06  897  
3d14c5d2 Yehuda Sadeh       2010-04-06  898  
16725b9d Sage Weil          2009-10-06  899  /*
16725b9d Sage Weil          2009-10-06  900   * mount: join the ceph cluster, 
and open root directory.
16725b9d Sage Weil          2009-10-06  901   */
3f384954 Yan, Zheng         2016-04-21  902  static struct dentry 
*ceph_real_mount(struct ceph_fs_client *fsc)
16725b9d Sage Weil          2009-10-06  903  {
16725b9d Sage Weil          2009-10-06  904     int err;
16725b9d Sage Weil          2009-10-06  905     unsigned long started = 
jiffies;  /* note the start time */
16725b9d Sage Weil          2009-10-06  906     struct dentry *root;
16725b9d Sage Weil          2009-10-06  907  
132ca7e1 Yan, Zheng         2016-03-12  908     dout("mount start %p\n", fsc);
3d14c5d2 Yehuda Sadeh       2010-04-06  909     
mutex_lock(&fsc->client->mount_mutex);
16725b9d Sage Weil          2009-10-06  910  
132ca7e1 Yan, Zheng         2016-03-12  911     if (!fsc->sb->s_root) {
ce2728aa Yan, Zheng         2016-09-14  912             const char *path;
3d14c5d2 Yehuda Sadeh       2010-04-06  913             err = 
__ceph_open_session(fsc->client, started);
16725b9d Sage Weil          2009-10-06  914             if (err < 0)
16725b9d Sage Weil          2009-10-06  915                     goto out;
16725b9d Sage Weil          2009-10-06  916  
1d8f8360 Yan, Zheng         2017-06-27  917             /* setup fscache */
1d8f8360 Yan, Zheng         2017-06-27  918             if 
(fsc->mount_options->flags & CEPH_MOUNT_OPT_FSCACHE) {
1d8f8360 Yan, Zheng         2017-06-27  919                     err = 
ceph_fscache_register_fs(fsc);
1d8f8360 Yan, Zheng         2017-06-27  920                     if (err < 0)
1d8f8360 Yan, Zheng         2017-06-27  921                             goto 
out;
1d8f8360 Yan, Zheng         2017-06-27  922             }
1d8f8360 Yan, Zheng         2017-06-27  923  
ce2728aa Yan, Zheng         2016-09-14  924             if 
(!fsc->mount_options->server_path) {
ce2728aa Yan, Zheng         2016-09-14  925                     path = "";
ce2728aa Yan, Zheng         2016-09-14  926                     dout("mount 
opening path \\t\n");
ce2728aa Yan, Zheng         2016-09-14  927             } else {
ce2728aa Yan, Zheng         2016-09-14  928                     path = 
fsc->mount_options->server_path + 1;
ce2728aa Yan, Zheng         2016-09-14  929                     dout("mount 
opening path %s\n", path);
ce2728aa Yan, Zheng         2016-09-14  930             }
18106734 Chengguang Xu      2018-02-09  931  
18106734 Chengguang Xu      2018-02-09 @932             err = 
ceph_fs_debugfs_init(fsc);
18106734 Chengguang Xu      2018-02-09  933             if (err < 0)
18106734 Chengguang Xu      2018-02-09  934                     goto out;
18106734 Chengguang Xu      2018-02-09  935  
ce2728aa Yan, Zheng         2016-09-14  936             root = 
open_root_dentry(fsc, path, started);
16725b9d Sage Weil          2009-10-06  937             if (IS_ERR(root)) {
16725b9d Sage Weil          2009-10-06  938                     err = 
PTR_ERR(root);
16725b9d Sage Weil          2009-10-06  939                     goto out;
16725b9d Sage Weil          2009-10-06  940             }
ce2728aa Yan, Zheng         2016-09-14  941             fsc->sb->s_root = 
dget(root);
31ca5878 Geert Uytterhoeven 2016-10-13  942     } else {
31ca5878 Geert Uytterhoeven 2016-10-13  943             root = 
dget(fsc->sb->s_root);
3d14c5d2 Yehuda Sadeh       2010-04-06  944     }
16725b9d Sage Weil          2009-10-06  945  
3d14c5d2 Yehuda Sadeh       2010-04-06  946     fsc->mount_state = 
CEPH_MOUNT_MOUNTED;
16725b9d Sage Weil          2009-10-06  947     dout("mount success\n");
a7f9fb20 Al Viro            2010-07-26  948     
mutex_unlock(&fsc->client->mount_mutex);
a7f9fb20 Al Viro            2010-07-26  949     return root;
16725b9d Sage Weil          2009-10-06  950  
132ca7e1 Yan, Zheng         2016-03-12  951  out:
132ca7e1 Yan, Zheng         2016-03-12  952     
mutex_unlock(&fsc->client->mount_mutex);
132ca7e1 Yan, Zheng         2016-03-12  953     return ERR_PTR(err);
16725b9d Sage Weil          2009-10-06  954  }
16725b9d Sage Weil          2009-10-06  955  

:::::: The code at line 932 was first introduced by commit
:::::: 18106734b512664a8541026519ce4b862498b6c3 ceph: fix dentry leak when 
failing to init debugfs

:::::: TO: Chengguang Xu <cgxu...@icloud.com>
:::::: CC: Ilya Dryomov <idryo...@gmail.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to