Re: [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c

2015-05-27 Thread Dan Carpenter
On Wed, May 27, 2015 at 03:01:37PM +, Simmons, James A. wrote: On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote: @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) if (nalloc * sizeof(*ifr) PAGE_CACHE_SIZE) { toobig = 1;

RE: [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c

2015-05-27 Thread Simmons, James A.
On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote: @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) if (nalloc * sizeof(*ifr) PAGE_CACHE_SIZE) { toobig = 1; nalloc = PAGE_CACHE_SIZE/sizeof(*ifr); -

RE: [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c

2015-05-27 Thread Simmons, James A.
Don't split string literals, it makes them hard to grep for. Will fix. The CWARN will go over 80 characters but from the recent emails that is more acceptable. If this is the only problem then this patch set it ready. Normally the right thing to do here would be to send a fixed [patch