Re: [patch] staging: comedi: pcmuio: remove an unneeded check

2013-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2013 at 11:02:45AM +0100, Ian Abbott wrote: > On 2013-08-20 10:00, Dan Carpenter wrote: > >"devpriv" is non-NULL at this point. We dereference it earlier in the > >function and the inconsistent checking upsets static checkers. We don't > >need to check "devpriv->sprivs" because kf

Re: [patch] staging: comedi: pcmuio: remove an unneeded check

2013-08-20 Thread Ian Abbott
On 2013-08-20 10:00, Dan Carpenter wrote: "devpriv" is non-NULL at this point. We dereference it earlier in the function and the inconsistent checking upsets static checkers. We don't need to check "devpriv->sprivs" because kfree() accepts NULL pointers. Signed-off-by: Dan Carpenter diff --g

[patch] staging: comedi: pcmuio: remove an unneeded check

2013-08-20 Thread Dan Carpenter
"devpriv" is non-NULL at this point. We dereference it earlier in the function and the inconsistent checking upsets static checkers. We don't need to check "devpriv->sprivs" because kfree() accepts NULL pointers. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/comedi/drivers/pcmuio.c