Re: [patch v2] staging: bcm2835-camera: fix error handling in init

2017-02-18 Thread walter harms
looks more readable now :) Acked-by: wha...@bfs.de Am 18.02.2017 00:20, schrieb Dan Carpenter: > The unwinding here isn't right. We don't free gdev[0] and instead > free 1 step past what was allocated. Also we can't allocate "dev" then > we should unwind instead of returning directly. > >

[patch v2] staging: bcm2835-camera: fix error handling in init

2017-02-17 Thread Dan Carpenter
The unwinding here isn't right. We don't free gdev[0] and instead free 1 step past what was allocated. Also we can't allocate "dev" then we should unwind instead of returning directly. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.") Signed-off-by: Dan