[PATCH v4] staging: most: Delete an error message for a failed memory allocation

2019-07-14 Thread Keyur Patel
This error message for a failed memory allocation is redundant as kfifo_alloc just calls kmalloc_array without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v4: - change subject line - improve commit description - fix checkpatch warning drivers/s

Re: [v4] staging: most: Delete an error message for a failed memory allocation

2019-07-14 Thread Markus Elfring
> --- > Changes in v4: I find this change log still incomplete. You have chosen to adjust the commit message once more. (Some contributors might be also not satisfied with this variant.) Such a change requires to increase the corresponding patch version number, doesn't it? Regards, Markus _

Re: [v4] staging: most: Delete an error message for a failed memory allocation

2019-07-14 Thread Keyur Patel
I think commit message is clear enough to understand why this is needed. You can send me what should I include in commit description and I will add and send it again. Otherwise, Greg can comment on this. Thanks. On Sun, Jul 14, 2019 at 06:55:30PM +0200, Markus Elfring wrote: > > --- > > Changes

Re: [v4] staging: most: Delete an error message for a failed memory allocation

2019-07-14 Thread Markus Elfring
> I think commit message is clear enough to understand why this is needed. There are differences to consider between the involved software developers. > You can send me what should I include in commit description The clarification should be continued with the number “v5” in the message subject.