Re: Getting the ccree driver out of staging

2018-01-21 Thread Gilad Ben-Yossef
On Thu, Jan 11, 2018 at 10:42 AM, Dan Carpenter wrote: > Here are my remaining Smatch warnings: > > drivers/staging/ccree/cc_driver.c:219 init_cc_resources() > error: '%pa' can only be followed by one of [dp] > > drivers/staging/ccree/cc_driver.c >217 >218 if (rc) { >2

Re: Getting the ccree driver out of staging

2018-01-11 Thread Dan Carpenter
Here are my remaining Smatch warnings: drivers/staging/ccree/cc_driver.c:219 init_cc_resources() error: '%pa' can only be followed by one of [dp] drivers/staging/ccree/cc_driver.c 217 218 if (rc) { 219 dev_err(dev, "Failed in dma_set_mask, mask=%par\n"

Re: Getting the ccree driver out of staging

2018-01-10 Thread Herbert Xu
On Thu, Jan 11, 2018 at 08:33:00AM +0200, Gilad Ben-Yossef wrote: > > Herbert, it's up to you - shall I send a new patch set or do you want to just > move what's in the staging tree? Please send a new patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: h

Re: Getting the ccree driver out of staging

2018-01-10 Thread Gilad Ben-Yossef
On Wed, Jan 10, 2018 at 6:39 PM, Greg Kroah-Hartman wrote: > On Wed, Jan 10, 2018 at 08:54:55AM +0200, Gilad Ben-Yossef wrote: >> Hi folks, >> >> With the enormous help of people in the to and CCed lists I've gotten >> the ccree driver to a point I believe it is ready to graduate out of >> the sta

Re: Getting the ccree driver out of staging

2018-01-10 Thread Greg Kroah-Hartman
On Wed, Jan 10, 2018 at 08:54:55AM +0200, Gilad Ben-Yossef wrote: > Hi folks, > > With the enormous help of people in the to and CCed lists I've gotten > the ccree driver to a point I believe it is ready to graduate out of > the staging tree: > > - The code base has been reduced by something by 3

Getting the ccree driver out of staging

2018-01-09 Thread Gilad Ben-Yossef
Hi folks, With the enormous help of people in the to and CCed lists I've gotten the ccree driver to a point I believe it is ready to graduate out of the staging tree: - The code base has been reduced by something by 30% and is *much* more readable and manageable. - The very few checkpatch warnin