RE: [HPDD-discuss] [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-28 Thread Patrick Farrell
: [HPDD-discuss] [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote: 1827 if (valid != 0) { 1828 cl_object_attr_lock(obj); 1829 cl_object_attr_set(env, obj, attr, valid); 1830

Re: [HPDD-discuss] [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-28 Thread Dan Carpenter
On Fri, Nov 28, 2014 at 03:45:24PM +, Patrick Farrell wrote: Dan, I disagree about the change suggested here. In this particular code, 'object_attr' is distinct from 'attr', as in a 'setattr' call on an inode. 'cl_object' is a distinct thing from an inode/file on disk, and specifying