RE: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-26 Thread Thomas Shao
Robo Bot; > jasow...@redhat.com; KY Srinivasan; Haiyang Zhang > Subject: Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using > host time sample > > In CENTOS and RHEL 6 and upwards the official way would be to use > > /usr/sbin/tickadj > > which is provided by nt

Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-26 Thread Mike Surcouf
In CENTOS and RHEL 6 and upwards the official way would be to use /usr/sbin/tickadj which is provided by ntp/chrony package This dependency on user space packages that may or may not be installed is going to cause a lot of confusion in an already confused space. Are we sure theres no other way?

Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-26 Thread Mike Surcouf
>> What happens when adjtimex is not present? >> Is there no kernel space function for that? >> Does this patch affect "not setting correct time on restore" or "not setting >> correct time on live migration" bug? >> > > If adjtimex is not present, then the slew time part didn't take effect. > Ther

RE: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-26 Thread Thomas Shao
; jasow...@redhat.com; KY Srinivasan; Haiyang Zhang > Subject: Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using > host time sample > > > +/* helper function to call adjtimex command in user mode */ static > > +void run_adjtimex_cmd(s64 tickv

Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-26 Thread Mike Surcouf
> +/* helper function to call adjtimex command in user mode */ > +static void run_adjtimex_cmd(s64 tickvalue) > +{ > + char *argv[4], *envp[3]; > + char str_tickvalue[20]; > + > + sprintf(str_tickvalue, "%lld", tickvalue); > + > + argv[0] = "/sbin/adjtimex"; > + argv[1

RE: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-25 Thread Thomas Shao
@canonical.com; jasow...@redhat.com; KY Srinivasan; Haiyang Zhang > Subject: Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using > host time sample > > On Tue, Sep 23, 2014 at 09:56:10AM +0200, Olaf Hering wrote: > > On Tue, Sep 23, Thomas Shao wrote: > > >

Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-24 Thread Sitsofe Wheeler
On Tue, Sep 23, 2014 at 09:56:10AM +0200, Olaf Hering wrote: > On Tue, Sep 23, Thomas Shao wrote: > > > In current hyper-v time sync service,it only gets the initial clock time > > from the host. It didn't process the following time samples. This change > > introduced a module parameter called hos

RE: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-23 Thread Thomas Shao
at.com; KY Srinivasan; Haiyang Zhang > Subject: Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using > host time sample > > On Tue, Sep 23, Thomas Shao wrote: > > > In current hyper-v time sync service,it only gets the initial clock > > time from the ho

Re: [PATCH] Drivers: hv: util: Implement Time Synchronization using host time sample

2014-09-23 Thread Olaf Hering
On Tue, Sep 23, Thomas Shao wrote: > In current hyper-v time sync service,it only gets the initial clock time > from the host. It didn't process the following time samples. This change > introduced a module parameter called host_time_sync. If it is set to true, > the guest will periodically sychro