These days comedi drivers are looking really nice. :) You will need to
resend because it's missing a change log and a Signed-off-by line. Wait
for Ian or Hartley to comment before resending. I had a few minor style
nits mentioned inline below. Run the patch through
`scripts/checkpatch.pl --str
On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote:
>
> create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
Hello Rostislav,
As pointed out by Dan Carpenter, you need to add a change log and
Signed-off-by lines to this patch.
Overall this looks pretty good. Comments below.
> di
Hello Hartley (and Dan);
Thank you for the review. I do agree with most of the things, however I
would like to explain/discuss a few of them...
On Thu, 2014-01-02 at 18:38 +, Hartley Sweeten wrote:
> On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote:
> >
> > create mode 100644 dri
On Sun, Jan 05, 2014 at 04:04:04PM +0100, Rostislav Lisovy wrote:
> Hello Hartley (and Dan);
> Thank you for the review. I do agree with most of the things, however I
> would like to explain/discuss a few of them...
>
> On Thu, 2014-01-02 at 18:38 +, Hartley Sweeten wrote:
> > On Monday, Dece
On 2014-01-02 18:38, Hartley Sweeten wrote:
On Monday, December 30, 2013 6:37 PM, Rostislav Lisovy wrote:
[snip]
+static int mf6x4_dio_insn_bits(struct comedi_device *dev,
+struct comedi_subdevice *s,
+struct comedi_insn *insn, unsigned in
On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
> This patch adds Comedi driver for Humusoft MF634 (PCIe) and
> MF624 (PCI) data acquisition cards. The legacy card Humusoft
> MF614 is not supported. More info about the cards may be found
> at http://humusoft.cz/produkty/datacq/
>
Hello Dan;
On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote:
> On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
> > This patch adds Comedi driver for Humusoft MF634 (PCIe) and
> > MF624 (PCI) data acquisition cards. The legacy card Humusoft
> > MF614 is not supported. More i
On 2014-01-08 08:35, Rostislav Lisovy wrote:
Hello Dan;
On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote:
On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
This patch adds Comedi driver for Humusoft MF634 (PCIe) and
MF624 (PCI) data acquisition cards. The legacy card Humu
On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote:
> On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
> > This patch adds Comedi driver for Humusoft MF634 (PCIe) and
> > MF624 (PCI) data acquisition cards. The legacy card Humusoft
> > MF614 is not supported. More info about t
On 2014-01-09 22:46, Rostislav Lisovy wrote:
This patch adds Comedi driver for Humusoft MF634 (PCIe) and
MF624 (PCI) data acquisition cards. The legacy card Humusoft
MF614 is not supported. More info about the cards may be found
at http://humusoft.cz/produkty/datacq/
The driver was tested with bo
10 matches
Mail list logo
