RE: [PATCH] staging: comedi: das1800: remove unused variable

2016-04-06 Thread Hartley Sweeten
On Wednesday, April 06, 2016 3:41 AM, Ian Abbott wrote: > On 06/04/16 10:41, Ian Abbott wrote: >> On 06/04/16 02:21, Hartley Sweeten wrote: >>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: The variable unipolar was never used. Signed-off-by: Sudip Mukherjee

RE: [PATCH] staging: comedi: das1800: remove unused variable

2016-04-06 Thread Hartley Sweeten
On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukherjee >>> --- >>> >>> There

Re: [PATCH] staging: comedi: das1800: remove unused variable

2016-04-06 Thread Ian Abbott
On 06/04/16 10:41, Ian Abbott wrote: On 06/04/16 02:21, Hartley Sweeten wrote: On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: The variable unipolar was never used. Signed-off-by: Sudip Mukherjee --- There may be a chance that reading from

Re: [PATCH] staging: comedi: das1800: remove unused variable

2016-04-06 Thread Ian Abbott
On 06/04/16 02:21, Hartley Sweeten wrote: On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: The variable unipolar was never used. Signed-off-by: Sudip Mukherjee --- There may be a chance that reading from DAS1800_CONTROL_C is necessary before reading

RE: [PATCH] staging: comedi: das1800: remove unused variable

2016-04-05 Thread Hartley Sweeten
On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: > The variable unipolar was never used. > > Signed-off-by: Sudip Mukherjee > --- > > There may be a chance that reading from DAS1800_CONTROL_C is necessary > before reading from DAS1800_STATUS. If that is