nuxfoundation.org>; Richard Cochran
> <richardcoch...@gmail.com>; Ruxandra Ioana Ciocoi Radulescu
> <ruxandra.radule...@nxp.com>
> Subject: Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware
> timestamping
>
> On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo
;gre...@linuxfoundation.org>; dan.carpen...@oracle.com;
> Ruxandra Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com>
> Subject: Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware
> timestamping
>
> On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:
&g
On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:
> +/* PTP nominal frequency 1GHz */
> +#define DPAA2_PTP_NOMINAL_FREQ_PERIOD_NS 1
Nit: Frequency is the inverse of the period. It can be one or the
other, not both.
Why not call it simply DPAA2_PTP_CLK_PERIOD_NS?
You haven't
On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:
> @@ -275,6 +278,16 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv *priv,
>
> prefetch(skb->data);
>
> + /* Get the timestamp value */
> + if (priv->ts_rx_en) {
> + struct skb_shared_hwtstamps *shhwtstamps
