RE: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Michael Kelley
From: Lorenzo Pieralisi Sent: Tuesday, March 26, 2019 10:09 AM > On Thu, Mar 21, 2019 at 12:12:03AM +, Dexuan Cui wrote: > > > From: Michael Kelley > > > Sent: Wednesday, March 20, 2019 2:38 PM > > > > > > From: Dexuan Cui > > > > > > > > After a device is just created in new_pcichild_devi

Re: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Lorenzo Pieralisi
On Tue, Mar 26, 2019 at 06:01:32PM +, Dexuan Cui wrote: [...] > > > Have we reached a conclusion on this ? I would like to merge this series > > > given that it is fixing bugs and it has hung in the balance for quite > > > a while but it looks like Michael is not too happy about these patches

RE: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Dexuan Cui
nel.org; driverdev-devel@linuxdriverproject.org; Haiyang > Zhang ; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; vkuznets ; > marcelo.ce...@canonical.com; ja...@mellanox.com; sta...@vger.kernel.org > Subject: RE: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

Re: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-26 Thread Lorenzo Pieralisi
On Thu, Mar 21, 2019 at 12:12:03AM +, Dexuan Cui wrote: > > From: Michael Kelley > > Sent: Wednesday, March 20, 2019 2:38 PM > > > > From: Dexuan Cui > > > > > > After a device is just created in new_pcichild_device(), hpdev->refs is > > > set > > > to 2 (i.e. the initial value of 1 plus th

RE: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-20 Thread Dexuan Cui
> From: Michael Kelley > Sent: Wednesday, March 20, 2019 2:38 PM > > From: Dexuan Cui > > > > After a device is just created in new_pcichild_device(), hpdev->refs is set > > to 2 (i.e. the initial value of 1 plus the get_pcichild()). > > > > When we hot remove the device from the host, in Linux

RE: [PATCH 1/3] PCI: hv: Fix a memory leak in hv_eject_device_work()

2019-03-20 Thread Michael Kelley
From: Dexuan Cui > > After a device is just created in new_pcichild_device(), hpdev->refs is set > to 2 (i.e. the initial value of 1 plus the get_pcichild()). > > When we hot remove the device from the host, in Linux VM we first call > hv_pci_eject_device(), which increases hpdev->refs by get_pci